search

Virusrwj223 / pe

0 stars 0 forks source link

Overzelous input validation for addproject #3

Open Virusrwj223 opened 4 days ago

Virusrwj223 commented 4 days ago

Expected: The project name is flexible to take any name as no target demographic is mentioned. Hence, if I were to input a Japanse name, the input should work. Actual: The project name is not able to take in all project names for any user and the error is handled

image.png

Steps to reproduce: Input: addproject pid/1 pn/ユジン

Note from tester: I have the noted that only alpha numeric characters are allowed. However the UG does not mention the target cultural demographic. A company may be Japanese and be using this app. However, due to this inflexibility, they are unable to use it.

soc-pe-bot commented 1 day ago

Team's Response

Thanks for raising this issue.

As you have noted, we have stated that only alphanumeric characters are allowed.

While we agree that stating the target demographics would be helpful here, a viable workaround exists in this case, which would be to use Romaji instead of the Japanese characters.

At this stage of development, our product assumes names to mainly in English or Latin script. Accordingly, all our documentation is written in English.

See https://github.com/nus-cs2103-AY2425S1/forum/issues/802

Therefore, we think that this flaw is not in scope because localisation is generally a rather time-consuming and difficult task to do correctly. In this case, we have explicitly stated in our UG that the names must be alphanumeric and adding localisation is less important than the other features we have implemented at this iteration.

image.png

Nevertheless, thanks for pointing this out!

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]