Vis4Sense / HistoryMap

http://sensemap.io
60 stars 7 forks source link

make jasmine test running in the last version. #62

Closed kaidatavis closed 7 years ago

kaidatavis commented 7 years ago

It is the following code in the 'content-script.js' that stops the Jasmine testing. I commented it out and it is working now.

I am not sure what the code does; we will need to find a different way if it is important.

// Polling for the sake of my intern tests // var interval = setInterval(function() { // if(document.readyState === 'complete') { // clearInterval(interval); // chrome.runtime.sendMessage({loadURL: true}); // done(); // }
// }, 100);

// window.onload = function () {

// }

shahzaibkhan commented 7 years ago

That's all good.

On Thu, May 25, 2017 at 2:55 AM, Kai Xu notifications@github.com wrote:

It is the following code in the 'content-script.js' that stops the Jasmine testing. I commented it out and it is working now.

I am not sure what the code does; we will need to find a different way if it is important.

// Polling for the sake of my intern tests // var interval = setInterval(function() { // if(document.readyState === 'complete') { // clearInterval(interval); // chrome.runtime.sendMessage({loadURL: true}); // done(); // } // }, 100);

// window.onload = function () {

// }

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Vis4Sense/SenseMapExtension/issues/62#issuecomment-303862825, or mute the thread https://github.com/notifications/unsubscribe-auth/AAusWYB2h3FzhNjJFfFRIml9hZ4FN__5ks5r9Kc6gaJpZM4NgbyA .

--

-- --

Thanks & Regards,

Shahzaib Khan

Email shahzaib198@gmail.com | Blog http://shahzaibkhan.com/ | Twitter http://twitter.com/shahzaib_khan | Facebook http://www.facebook.com/shahzaib198 | Linkedin http://www.linkedin.com/in/shahzaibkhan

This message is intended for the recipient named above. It may contain confidential or privileged information. If you are not the intended recipient, please notify the sender immediately by replying to this message and then delete it from your system. Any form of unauthorized use or dissemination is prohibited. Risks are inherent in all internet communication. Each recipient is responsible for protecting its system from viruses and/or other harmful code and/or device. The sender is not responsible, and hereby disclaims all liabilities arising from or in relation to any viruses and/or other harmful code and/or device.