search

Vis4Sense / HistoryMap

http://sensemap.io
60 stars 7 forks source link

Rebuild shaz #81

Closed shahzaibkhan closed 7 years ago

shahzaibkhan commented 7 years ago

Kindly merge the test cases for the redirection and no new node.

kaidatavis commented 7 years ago

Good to see the progress! A few small issues: 1) please use the camel case for variable naming, so 'nonownodetest' should be 'noNewNodeTest' (not 'now'). This makes it easier to read. 2) please have a look of the new 'options.html' file in the 'rebuild' branch and follow its format. 3) please also update the test file name as shown in the latest rebuild branch.

kaidatavis commented 7 years ago

Please make sure it is merged to 'rebuild' not the 'master'.

shahzaibkhan commented 7 years ago

1) please use the camel case for variable naming, so 'nonownodetest' should be 'noNewNodeTest' (not 'now'). This makes it easier to read. - Fixed 2) please have a look of the new 'options.html' file in the 'rebuild' branch and follow its format. - DONE 3) please also update the test file name as shown in the latest rebuild branch. - DONE

shahzaibkhan commented 7 years ago

For the pull request: Kindly please check now.

kaidatavis commented 7 years ago

It is not quite ready yet. See my comments on the redirection and no new node testing issue.