fix(animation): rose animation not work when update twice. fix#2856 - Githubissues

VisActor / VChart

VChart, more than just a cross-platform charting library, but also an expressive data storyteller.

https://www.visactor.io/vchart

MIT License

769 stars 44 forks source link

fix(animation): rose animation not work when update twice. fix#2856 #2857

Closed skie1997 closed 2 days ago

skie1997 commented 2 days ago

[中文版模板 / Chinese template]

🤔 This is a ...

[ ] New feature
[x] Bug fix
[ ] TypeScript definition update
[ ] Bundle size optimization
[ ] Performance optimization
[ ] Enhancement feature
[ ] Refactoring
[ ] Update dependency
[ ] Code style optimization
[ ] Test Case
[ ] Branch merge
[ ] Release
[ ] Site / documentation update
[ ] Demo update
[ ] Workflow
[ ] Other (about what?)

🔗 Related issue link

close #2856

🔗 Related PR link

🐞 Bugserver case id

💡 Background and solution

连续两次updatespec，vgrammar走入图元匹配逻辑，但vchart remake图元导致匹配前后图元对象不是同一个，动画没执行。

排查到：crosshair visible设置为false之后，仍然走了create逻辑，导致updatespec前后对比失败

📝 Changelog

Language	Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

[ ] Doc is updated/provided or not needed
[ ] Demo is updated/provided or not needed
[ ] TypeScript definition is updated/provided or not needed
[ ] Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough