search

VisBOL / visbol-js

SBOLv rendering in JavaScript
visbol.org
BSD 2-Clause "Simplified" License
10 stars 3 forks source link

Merged interaction #103

Closed asadeg02 closed 5 years ago

asadeg02 commented 5 years ago

Addresses #99 #97 #85. The purpose of this pull request was to remove the redundancy from interaction diagrams. With this new approach all the interaction happening on top of a circuit are merged together and are rendered in one diagram; if the nonDNA part participating in the interaction is degraded then degradation is not shown in a separate diagram either, other wise it has to be shown separately. Also interactions are sorted so that inhibitions and stimulation are always rendered to the left of genetic productions. below is a segment of VisBOL rendering for a SBOL file final

For that SBOL, file these interactions are rendered separately. please note that since some of these proteins in that SBOL file don't participate in any other interaction with circuits, their degradation interactions has to be rendered separately, even though degradation interactions are merged into the circuit interactions. rest

Merge interactions algorithm is in "lib/displayList.js" and it merges interactions using a segment id which has been given to the segments using componentDefinitions uri in "lib/getDisplayList.js".

cjmyers commented 5 years ago

This looks great. I'm going to test this out now.

cjmyers commented 5 years ago

Looks like something is not checked in:

Error: Cannot find module './stimulatorArrow' from '/Users/myers/git/visbol-js/font/sbolv/interaction-arrows' at /Users/myers/git/synbiohub/node_modules/browser-resolve/node_modules/resolve/lib/async.js:55:21 at load (/Users/myers/git/synbiohub/node_modules/browser-resolve/node_modules/resolve/lib/async.js:69:43) at onex (/Users/myers/git/synbiohub/node_modules/browser-resolve/node_modules/resolve/lib/async.js:92:31) at /Users/myers/git/synbiohub/node_modules/browser-resolve/node_modules/resolve/lib/async.js:22:47 at FSReqCallback.oncomplete (fs.js:161:21)

cjmyers commented 5 years ago

Ah, I think I see the issue. You likely moved simulatorArrow to stimulatorArrow, but then did not commit stimulatorArrow

asadeg02 commented 5 years ago

Just Added it.

cjmyers commented 5 years ago

Looks great. Merging.