search

VisBOL / visbol-js

SBOLv rendering in JavaScript
visbol.org
BSD 2-Clause "Simplified" License
10 stars 3 forks source link

Problem with visbol composite rendering #104

Closed cjmyers closed 5 years ago

cjmyers commented 5 years ago

This file gives an exception:

TypeError: undefined is not an object (evaluating 'c[glyph.segmentIdentity].labelColor=l.colors[l.colorIndex++].colorName')

BBa_K1001755.zip

cjmyers commented 5 years ago

In testing your latest pull request, I ran into this bug. Any idea the issue?

asadeg02 commented 5 years ago

@cjmyers just fixed it. the problem had nothing to do with what has been done in the most recent pull request, it was a problem for how composite parts glyph label colors are mapped to their corresponding segment label colors. now that I have given each segment an id corresponding to their uri, I just figured out a much better and accurate way to do that. I'm about to create the pull request for that!

this is the rendering for this file: screen

cjmyers commented 5 years ago

Thanks much

Chris

Sent from my iPhone

On Dec 22, 2018, at 5:09 PM, asadeg02 notifications@github.com wrote:

@cjmyers just fixed it. the problem had nothing to do with what has been done in the most recent pull request, it was a problem for how composite parts glyph label colors are mapped to their corresponding segment label colors. now that I have given each segment an id corresponding to their uri, I just figured out a much better and accurate way to do that. I'm about to create the pull request for that!

this is the rendering for this file:

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

cjmyers commented 5 years ago

Works. Thanks again.