search

VisBOL / visbol-js

SBOLv rendering in JavaScript
visbol.org
BSD 2-Clause "Simplified" License
10 stars 3 forks source link

getDisplayList and tooltip string (a JSON can be more useful for general usage) #124

Closed linediconsine closed 2 years ago

linediconsine commented 2 years ago

Hi All, This code performs a difficult operation of unwrapping the SBOL file in a Javascript Object with many SBOL proprieties.

Thanks for making this code public, I would like to suggest an improvement :

in ./lib/getDisplayList most of the SBOL information is serialized in a string ( tooltip ), this fits the visbol-2 requirements but makes the code difficult to reuse.

I.e.

tooltip += 'Role: ' + sbolmeta.sequenceOntology[soTerm].name + '\n'`

if a getDisplyListJSON that provides this information in JSON format exists this code may be more elastic for different usages and Visbol-2 will not be impacted by this change

What do you think?

Tagging: @cjmyers

cjmyers commented 2 years ago

This sounds like a good change. @benjhatch what do you think?

benjhatch commented 2 years ago

I think this is a great idea. I agree that making it available as JSON in getDisplayList is much more useful. I will work on updating it :) Thanks for the helpful suggestion!

linediconsine commented 2 years ago

Thanks for the collaboration!

Marco

I will close this ticket as the functionality had been added to the main branch