search

VisBOL / visbol-js

SBOLv rendering in JavaScript
visbol.org
BSD 2-Clause "Simplified" License
10 stars 3 forks source link

Limit with omitted #79

Closed dany-fu closed 6 years ago

dany-fu commented 6 years ago

Issue #53 and #73 Renders 30 glyphs max, the 31st glyph is the omitted glyph

screen shot 2018-07-10 at 18 29 45

cjmyers commented 6 years ago

So, this actually will not work with SynBioHub. SBH does not use browser.js, but goes directly to getDisplayList. The addition of the omitted detail and the pruning of the extra segments should be done in getDisplayList.

cjmyers commented 6 years ago

This does not break anything, so it is fine to be merged, but I will leave this branch open, and a new pull request on this branch can be submitted later, which moves this functionality into getDisplayList.

dany-fu commented 6 years ago

Here, we are using the code that Zach had committed a while back for limiting, which is to slice the displayList. I closed the pull request after Arezoo raised the issue of how that could impact the interactions that she's currently working on, and it's also not an ideal long term solution if in the future we want to consider something like an expansion or some other way of rendering the rest of the glyphs. I think we should not limit the displayList but make the cut off during the rendering instead

cjmyers commented 6 years ago

Agreed. I will revert this one.

On Jul 11, 2018, at 1:10 PM, Dany notifications@github.com wrote:

Here, we are using the code that Zach had committed a while back for limiting, which is to slice the displayList. I closed the pull request after Arezoo raised the issue of how that could impact the interactions that she's currently working on, and it's also not an ideal long term solution if in the future we want to consider something like an expansion or some other way of rendering the rest of the glyphs. I think we should not limit the displayList but make the cut off during the rendering instead

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/VisBOL/visbol-js/pull/79#issuecomment-404278975, or mute the thread https://github.com/notifications/unsubscribe-auth/ADWD9860mzzlaK2LkPQHsXa3rIP5twWdks5uFk22gaJpZM4VKODb.