search

VisBOL / visbol-js

SBOLv rendering in JavaScript
visbol.org
BSD 2-Clause "Simplified" License
10 stars 3 forks source link

Flatten interactions #85

Open dany-fu opened 6 years ago

dany-fu commented 6 years ago

Don't render duplicate components individually (see mapsTo within Modules and FunctionalComponents)

cjmyers commented 6 years ago

This is an example file with MapsTos to indicate how interactions should be connected.

v2_circuit_0x78_2_A1_AmtR_module.zip

asadeg02 commented 5 years ago

@cjmyers Below is the rendering after merging the interactions, I have also merged degradations to be shown as part of circuit interactions. This way only interactions of type non-covelant-binding are rendered separately. right now it's kind of hard to merge them since proteins don't have any more space for any other interaction arrows. please let me know your thoughts on this!

combined

cjmyers commented 5 years ago

@asadeg02 these look very good. A couple small issues: 1) Let's put the inhibitions and stimulations to the left of the productions. 2) The stimulation arrow in the second figure is directed in the wrong direction. 3) As for non-covalent binding, you could put one reactant to the left and one above. For example, for Ara_AraC_protein, you could have protein, AraC_protein, to the left and the small molecule Ara above. Alternatively, we could have the degradations all go above, which gives you more room in the horizontal direction.