search

VisBOL / visbol-js

SBOLv rendering in JavaScript
visbol.org
BSD 2-Clause "Simplified" License
10 stars 3 forks source link

Change how composite part is found #91

Closed dany-fu closed 6 years ago

dany-fu commented 6 years ago

Because this information is more easily available in the SBOL, update the SBOL parser and create a new composite: true/false flag in displayList

dany-fu commented 6 years ago

@cjmyers is there a method in sboljs that detects which ComponentDefinition is the topmost level (the circuit)? Arezoo and I just looked into this issue and noticed that parsing the composite from the SBOL would not be more efficient than what is currently implemented if there is no way to tell which is the top level CD.

cjmyers commented 6 years ago

I don't think this is necessary. To determine if something is a composite, you simply can do:

  foreach CD 
       foreach Component in CD
              if (definition of Component has components) then this Component is a Composite
cjmyers commented 6 years ago

Completed.