search

VisTrails / DAT

The Data Analysis Tool, providing a simpler, plotting-oriented UI on top of VisTrails
3 stars 5 forks source link

Mac GUI issues #4

Closed remram44 closed 9 years ago

remram44 commented 9 years ago

(originally TRAC#16, 2013-02-28)

After overlay-settings was merged to master, I'm getting a bunch of issues in the GUI on Mac.

  • The string input widgets on the overlay settings are only about 2 pixels wide
  • Resizing a single cell in the spreadsheet does not show the black corner, and resizes the entire window
  • After opening and closing the overlay a few times after making a plot, python crashes

comment by @remram44:

  • The string input widgets on the overlay settings are only about 2 pixels wide

The ​documentation for QFormLayout states:

  • On Windows: Labels are left aligned, and expanding fields grow to fill the available space.
  • On Mac: Labels are right-aligned, the fields don't grow beyond their size hint.

This explains the difference we see between the OSes. I can use a QGridLayout instead, as I don't think we want to fix the widgets' size hint.

comment by @remram44:

  • The string input widgets on the overlay settings are only about 2 pixels wide

Fixed by b53a94d14f Setting the ​FieldGrowthPolicy might have worked too.

comment by benbu:

Resizing a single cell in the spreadsheet does not show the black corner, and resizes the entire window

Apparently the z-order of widgets can get messed up... Sometimes the "hide overlay" button is behind the overlay, and I just got the whole cell become unresponsive (as if behind an invisible widget).

comment by @remram44:

After opening and closing the overlay a few times after making a plot, python crashes

Just got a crash, I'm attaching the report from Mac OS. Looks like a NULL pointer dereference in Qt's mouse-handling code... crash-report.txt

comment by @remram44:

Resizing a single cell in the spreadsheet does not show the black corner, and resizes the entire window

After dropping a single overlay anywhere, the black corner allowing to resize cells disappears for all cells. I don't know why that is. Adding calls to raise() doesn't seem to help...

comment by @remram44:

I tracked down the resizer bug to the addition of the 'color' parameter in the pylab example plot. This adds a ColorWidget to the overlay.

It seems that removing the WA_PaintOnScreen attribute from the ColorChooserButton fixes the issue, although the documentation states that this attribute has no effect on Mac OS.

comment by @remram44:

Somehow the last change seems to also fix the crash, can you confirm?

comment by benbu:

Somehow the last change seems to also fix the crash, can you confirm?

Yeah, very strange. Seems to be running great on Mac now! Nice job!