Vishal-raj-1 / Awesome-JavaScript-Projects

This Repository contain awesome vanilla JavaScript projects.
https://vishal-raj-1.github.io/Awesome-JavaScript-Projects/
MIT License
1.81k stars 739 forks source link

[bug]: No icon image or theme switcher button #1944

Open sujit-shrc opened 1 year ago

sujit-shrc commented 1 year ago

Describe the bug

In the home page Navbar there is no icon image on theme switcher button

To Reproduce

Steps to reproduce the behavior:

  1. Go to Home page
  2. See on right side of the Navbar
  3. Click on theme switcher button
  4. The see there is no icon image in light/ dark theme

Issue

image

Expected behavior

Should have proper icons for light themes and dark theme

Environment (please complete the following information):

github-actions[bot] commented 1 year ago

Hi 😄, thanks for creating your first issue at AWESOME-JAVASCRIPT-PROJECTS, do read and follow the Code of Conduct and the Contribution Guidelines while contributing.

harshkushwaah commented 10 months ago

this might be happening because of using the online hosted icons buy their links and not actually storing the icons in the projects itself. The most simple and reliable solution would be to download the icons and use them locally from the images folder.

If you want me to solve this problem you can assign me the task. thanks