soc-se-bot
commented
2 years ago Team's Response
Actually the day which is deleted is day 1 and the index of other days will go forward automaticly. Hence, after you delete day 1, the previous day 2 will change to day 1. the day index represent the serial number of the day
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Deletion of days doesn't work properly
I added 2 days to my trip and when I gave the command to delete day 0, it deleted day 1 instead. Day 0 is still visible when I use the view all command. This is quite a big issue as you mentioned that deletion is irreversible in your UG.
[original: nus-cs2113-AY2122S1/pe-interim#604] [original labels: severity.High type.FunctionalityBug]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
Actually the day which is deleted is day 0 and the index of other days will go forward automaticly. Hence, after you delete day 0, the previous day 1 will change to day 0
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: The fact that days are reshuffled should have been made more clear within the UG. Deleting a day can have multiple interpretations. For example, a user is travelling for 5 days. Let's say the user only decides to log items on days 1, 3 and 5 of the trip as days 2 and 4 may be void of activites or the user may simply not wish to log items on those days. Thus, days 1, 3 and 5 are filled with items. However, if the user decides to delete day 1 due to a sudden change of plans, the days get reshuffled and 4 days now exist, with each label for each day changing. This can be confusing as the user may expect this to mean deleting a particular day and its activites, while keeping the remaining days and their labels intact. Granted, this wasn't the original intention of deleting a day. However, its purpose needs to be properly stated within the UG. A rather vague explanation for deleting a day is in the UG as shown below.
:question: Issue type
Team chose [type.FunctionalityBug]
Originally [type.FeatureFlaw]
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
:question: Issue severity
Team chose [severity.High]
Originally [severity.VeryLow]
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
According to the UG, we can delete a day by using the format shown below on a particular trip.
However, the day doesn't get deleted when I try to delete day 1 of "trip to KL", comprising 2 days. Day 2 simply gets deleted and the total number of the days is simply reduced, as shown below.
This may not be what users expect as some would expect this to mean deleting a particular day and its activites, while keeping the remaining days and their labels intact, and not deleting a day entirely from the schedule of a trip.