search

VishalWadhwa / jupiter-eclipse-plugin

Automatically exported from code.google.com/p/jupiter-eclipse-plugin
0 stars 0 forks source link

Investigate what other contributions Jupiter should make in its plugin.xml #24

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Jupiter Add Review Issue and markers only show up in some editors and not
others.  Is there something we can do to remedy this problem?

For example, Eclipse added an XML editor in 3.3.  Jupiter does not hook
into this but it probably should.  Same goes with the Ant editor.

The documentation for the plugin xml is here:
http://help.eclipse.org/help33/index.jsp

Marking this as an enhancement since there is a workaround that can be used
in the mean time.  Opening any files in the Text Editor will make them work
with Jupiter.

Original issue reported on code.google.com by jsakuda on 23 Apr 2008 at 7:23

GoogleCodeExporter commented 9 years ago 
Chris Goy has sent me this link that may be of some benefit.

http://wiki.eclipse.org/Menu_Contributions#Menu_URIs

Original comment by jsakuda on 29 Apr 2008 at 2:18

GoogleCodeExporter commented 9 years ago 
Realizing I made this terrible typo in the summary.  Fixing that.

Original comment by jsakuda on 29 May 2008 at 6:54

GoogleCodeExporter commented 9 years ago 
People seem to want this so I will try to fix it for 3.4.0.

Original comment by jsakuda on 18 Jul 2008 at 1:56

GoogleCodeExporter commented 9 years ago 
Deferring to a later release.  Chris will look into this but at the moment we 
are
short on resources.

Original comment by jsakuda on 17 Aug 2008 at 11:21

GoogleCodeExporter commented 9 years ago 
Adding the following entry to the popupMenus extension point appears to do the 
trick:

<objectContribution objectClass="org.eclipse.core.resources.IResource"
   id="edu.hawaii.ics.csdl.jupiter.ui.action.contribution.popup.objectICompilationUnit"
   adaptable="true">
   <action
      label="%actionLabel"
      icon="icons/jupiter.gif"
      helpContextId="edu.hawaii.ics.csdl.jupiter.ui.action.ReviewAdditionActionDelegate"
      class="edu.hawaii.ics.csdl.jupiter.ui.action.ReviewAdditionActionDelegate"
      menubarPath="add"
      enablesFor="1"
      id="edu.hawaii.ics.csdl.jupiter.ui.action.ReviewAdditionActionDelegate">
   </action>
</objectContribution>

Note that the objectClass is IResource and that "adaptable" has to be set to 
"true".

-Peter

Original comment by pwhi...@gmail.com on 9 Oct 2008 at 11:43

GoogleCodeExporter commented 9 years ago 
Thanks Peter, I'll try that out!  I haven't had a chance to really understand 
the
plugin.xml that well.

Original comment by jsakuda on 9 Oct 2008 at 11:49

GoogleCodeExporter commented 9 years ago 
I'm happy to help - thanks for creating an excellent plugin. I'll admit I 
caught a
lucky break though - I noticed that checkstyle was appearing in my context menu 
for
ActionScript files so I looked at its plugin.xml file to see how it was 
configured. :-)

Original comment by pwhi...@gmail.com on 10 Oct 2008 at 1:41

GoogleCodeExporter commented 9 years ago 
I have tested the popupMenus contribution above and it does seem to work in the 
sense
that it adds the menu option.  However, the purple markers do not appear to be
working for other editors.  I am trying to figure out how to fix it but I 
haven't had
any luck.

Original comment by jsakuda on 21 Oct 2008 at 9:07

GoogleCodeExporter commented 9 years ago 
This issue has been holding back the release for too long.  I am going to defer 
it yet again to a later release.  I 
think I may have to actively go out and get help from people who know more than 
I do.

Original comment by jsakuda on 27 Oct 2008 at 9:45

GoogleCodeExporter commented 9 years ago 
Comment #5 does the trick for PDT (http://www.eclipse.org/pdt) also.

Original comment by spek...@gmail.com on 21 Jan 2009 at 3:09

GoogleCodeExporter commented 9 years ago 
Postponing yet again in preparation to release 3.4.2 early.

Original comment by jsakuda on 5 Feb 2009 at 6:49

GoogleCodeExporter commented 9 years ago 
The tweak by comment #5 works great for latest version of Eclipse PDT.

Original comment by adam.kun...@gmail.com on 28 Apr 2009 at 1:20

GoogleCodeExporter commented 9 years ago 
I've decided to finally go ahead and push the plugin.xml changes based on 
Peter's snippet.  It is not perfect and I 
have only tested the plugin.xml I have against Eclipse with PDT and CDT 
downloaded as plugins.

I know for sure the markers DO NOT work with the XML editor.  I will open a new 
bug for it so I can close this 
"catch all" issue.  Opening issues for each individual problem provides better 
tracking of issues.

Original comment by jsakuda on 8 Jun 2009 at 3:20

GoogleCodeExporter commented 9 years ago 
Adding in contribution to IFile types.  Known bug: Markers DO NOT work in XML 
Editor.  Will open a 
new issue.

Original comment by jsakuda on 8 Jun 2009 at 4:27