VishnuAmit / LapProFix

MIT License
1 stars 18 forks source link

Added responsive Search bar and phone number display on Dashboard Navbar #18

Closed Atv23 closed 3 days ago

Atv23 commented 4 days ago

Changes made:

Screenshots:

Screenshot 2024-10-08 102955 Screenshot 2024-10-08 103016 Screenshot 2024-10-08 103100 Screenshot 2024-10-08 103120

vercel[bot] commented 4 days ago

Deployment failed with the following error:

Resource is limited - try again in 8 hours (more than 100, code: "api-deployments-free-per-day").
Atv23 commented 4 days ago

I believe my changes weren't responsible for the deployment failure, as it seems to be related to resource limits on the hosting platform.

VishnuAmit commented 4 days ago

@Atv23 . The resource is limited and i am sorting it out and its not your mistake.

Just one small change: image

Make the location search bar look like this

Put the phone number inside the hamburger. Inside hamburger: call icon - phone number

Since there are issues with deployment, you can add a video demonstrating the responsiveness.

Thanks.

VishnuAmit commented 4 days ago

I have updated my last comment. I think in this way, the location bar would be wider in mobile screen. Refering your 3rd image.

Atv23 commented 3 days ago

I cant find the issue anywhere in the repo? What happened? You didnt accept the PR also

On Tue, 8 Oct 2024 at 11:26, Vishnu Kasilya @.***> wrote:

I have updated my last comment. I think in this way, the location bar would be wider in mobile screen. Refering your 3rd image.

— Reply to this email directly, view it on GitHub https://github.com/VishnuAmit/LapProFix/pull/18#issuecomment-2398914794, or unsubscribe https://github.com/notifications/unsubscribe-auth/AY6NFVK6V6ZMOUDJDPFSAWTZ2NXYLAVCNFSM6AAAAABPRKZPHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJYHEYTINZZGQ . You are receiving this because you were mentioned.Message ID: @.***>

VishnuAmit commented 3 days ago

https://github.com/VishnuAmit/LapProFix/issues/11. You can find the issue here. I didnt' accept the PR because few changes are needed to be done.

@Atv23 . The resource is limited and i am sorting it out and its not your mistake.

Just one small change: image

Make the location search bar look like this

Put the phone number inside the hamburger. Inside hamburger: call icon - phone number

Since there are issues with deployment, you can add a video demonstrating the responsiveness.

Thanks.

Atv23 commented 3 days ago

Ok got it, will work on it, thanks!! Does the search bar has to be functional too?

VishnuAmit commented 3 days ago

Umm, Not needed for now. But the idea is when we enter any permitted location on the search bar, it should load and display the same content, If not it should display a page Oops, We didnt expand our services to your location yet!

Its your wish, if you are willing to do this as well in the same issue. (Optional)

Atv23 commented 3 days ago

the sign in has some issues with the current commit I guess, not able to access the dashboard section

VishnuAmit commented 3 days ago

Hey @Atv23 Sorry. we are fixing it. As of now, you could connect it to your mongoDB database and paste the connection string in db->config.js.

Following that, try to sign up and then sign in (only google works now) , then you can access the dashboard page. User your google id and secret in your .env file.

Sorry for this. Let me know if you can reach the dashboard page.

VishnuAmit commented 3 days ago

@Atv23 It's fixed. You can signup/signin and access the dashboard page. Connect it your mongodb.

Atv23 commented 1 day ago

Sorry for the delay but the Signin/Signup still wasn't functioning whenever I tried, I changed home page path and disabled session to make the changes which I ensured to change it back. Please consider the change, I requested a PR