VishnuAmit / LapProFix

MIT License
1 stars 18 forks source link

fixed #22: Images of blog authors not loading #30

Closed shreyansh1410 closed 1 day ago

shreyansh1410 commented 2 days ago

The images of blog authors are now loading

vercel[bot] commented 2 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lap-pro-fix ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 1:56pm
lap-pro-fix-4gpy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 1:56pm
lap-pro-fix-bo2t ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 1:56pm
lap-pro-fix-hxqn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 1:56pm
lap-pro-fix-k923 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 1:56pm
lap-pro-fix-m8bt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 1:56pm
lap-pro-fix-p321 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 1:56pm
lap-pro-fix-yup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 1:56pm
lap-pro-fix134 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 1:56pm
lapprofix ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 1:56pm
VishnuAmit commented 2 days ago

hey @shreyansh1410 , Could you put up a video on what you did, it would be easy for me to see the changes, as i need to fix the deployment failure errors.

Show in both mobile and desktop version to see the animation works correctly.

shreyansh1410 commented 2 days ago

Yeah, I will

shreyansh1410 commented 2 days ago

https://github.com/user-attachments/assets/c7f64aba-c9d8-4433-863a-622fe6738bc5

VishnuAmit commented 2 days ago

Hey, no need to take the length of the text as width of the box. You can have a fixed size and wrap the text. You can show a video of mobile version as well.

Note : Kindly pull the latest changes to your local machine as we have solved the deployment issue.

shreyansh1410 commented 1 day ago

This is how it looks on web screens:

https://github.com/user-attachments/assets/4da42cd1-32ff-43d4-8309-ab3e0f1dc353

This is how it looks on mobile:

https://github.com/user-attachments/assets/135ff467-03a1-4dee-8a53-676ce74bb24f

shreyansh1410 commented 1 day ago

I accidentally solved both the issues in this pr itself, which means it will be counted as a single pr for hacktoberfest, is there any way for me to create separate pr for both the issues?

VishnuAmit commented 1 day ago

Hey..looks cool. But can you avoid that sudden jerk and make it roll smoothly. And in mobile version, I cant see the entire section. It just resets to the starting point (sudden jerk here too) and when i try to swipe it, its not viewing the rest of the section.

Edit: Yes. You can create a separate issue and raise your first PR there and then same goes with 2nd pr