VishnuAmit / LapProFix

MIT License
1 stars 18 forks source link

[Refactor] πŸ”§ Add Best Practices for Configuration, Dependency Management, and Commit Messages #32

Closed samiurprapon closed 2 days ago

samiurprapon commented 2 days ago

Summary

This PR brings some best practices into the project by adding .env to .gitignore, cleaning up redundant lock files (package-lock.json), and introducing a standardized commit message format for better clarity and maintainability.

Related Issue: #31

🧬 Type of Change

✨ What’s New

πŸ”’ Why These Changes?

βœ… Changes Made

πŸ› οΈ Checklist Before Review

πŸ’‘ Additional Information

This project is built on a backdated version of Next.js, which means updating certain configurations could cause issues. As a precaution, I’ve used eslint@8 to ensure everything remains compatible and stable with the current setup.

vercel[bot] commented 2 days ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
lap-pro-fix βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 10, 2024 2:13am
lap-pro-fix-4gpy βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 10, 2024 2:13am
lap-pro-fix-bo2t βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 10, 2024 2:13am
lap-pro-fix-hxqn βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 10, 2024 2:13am
lap-pro-fix-k923 βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 10, 2024 2:13am
lap-pro-fix-m8bt βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 10, 2024 2:13am
lap-pro-fix-p321 βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 10, 2024 2:13am
lap-pro-fix-yup βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 10, 2024 2:13am
lap-pro-fix134 βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 10, 2024 2:13am
lapprofix βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 10, 2024 2:13am
VishnuAmit commented 2 days ago

I just reviewed your commits and everything looks solid and the deployment issue has been solved. As you mentioned, using docker and yea I have thought about it earlier but few things are needed to be done before deploying it through docker.