VishnuSanal / DialogMusicPlayer

A simple and minimal music player dialog :)
https://vishnusanal.github.io/posts/story-of-dialogmusicplayer/
GNU General Public License v3.0
83 stars 5 forks source link

[FIX] Crashes when play from Termux. #37

Closed luisadha closed 1 year ago

luisadha commented 1 year ago

Expected behavior Should be like the second image Crash logs If possible, add crash logs to help us figure out the problem.

Smartphone (please complete the following information):

Additional context problem play with termux

VishnuSanal commented 1 year ago

@luisadha Hi, thanks for reaching out! I am sorry to hear you bumped into problems. From the Toast message in the screenshot provided, it looks like an issue with storage permission. Please verify that the read external storage permission is granted to DMP. Meanwhile I'll try reproducing the error from my side too. :)

luisadha commented 1 year ago

i will try a second time

luisadha commented 1 year ago

i think wrong permission, should be permission to file or change system setting? In images permission is requested for images and media. Cmiiw

luisadha commented 1 year ago

I usually use size utilities or sometimes use the default Xiaomi music player application. I'm just trying to use this app🙂

VishnuSanal commented 1 year ago

i think wrong permission, should be permission to file or change system setting? In images permission is requested for images and media. Cmiiw

yeah, the name of the permission is android.permission.READ_EXTERNAL_STORAGE & Android shows it as images & media (since I presume it would make more sense to a common user). DMP basically wants access to read the storage (to access the music file being played), it's just that Android uses wordings like "images" & "media" to prompt to the user.

I usually use size utilities or sometimes use the default Xiaomi music player application. I'm just trying to use this app

thank you & much appreciated that you took the effort to try use DMP, to try match it to your usecase & report back the stumbling blocks you faced meanwhile to me :)

thanks again, try granting the permission & please LMK whether that fixes the issue

luisadha commented 1 year ago

I found a solution. After seeing a comparison of 2 similar applications the dmp application does not include permissions to all files while the other apps includes 2 permissions namely images and media and all file

VishnuSanal commented 1 year ago

I found a solution. After seeing a comparison of 2 similar applications the dmp application does not include permissions to all files while the other apps includes 2 permissions namely images and media and all file

yeah, we do not really need the "all files permission", it is requesting access to the whole storage -- applications like file managers would need that.

luisadha commented 1 year ago

so are you going to add that permission? Or let DMP run like that

VishnuSanal commented 1 year ago

hi, I tried reproducing this issue on my daily driver. steps:

are these the steps you followed too? or am I missing something? please verify.

so are you going to add that permission? Or let DMP run like that

um... DMP doesn't need that permission at all to work + I'm pretty sure adding all file permission would raise some eyebrows on FDroid for being suspicious (& can't even publish on play store as we ain't a file manager).

luisadha commented 1 year ago

I verified it's the same

VishnuSanal commented 1 year ago

@luisadha must be fixed with the latest release v2.0.0, please reopen if it is not the case :)

luisadha commented 1 year ago

Good job guys the app is as expected, but is it running in the background? When I touch the part outside the DMP box/popup the app does not close if I touch the Quit button then the music stops as well as when I press the back button.

Did you forget to give support permission [Display on top of other apps].

Thank you for your attention Diterjemahkan dengan DeepL

luisadha commented 1 year ago

@VishnuSanal Because I see other 2 music player apps on my device need those special permissions

luisadha commented 2 months ago

@VishnuSanal i'm fix this by bash my function "hide_soft_keyboard"

Please keep the application even if the soft keyboard is open

https://raw.githubusercontent.com/luisadha/alrc-termux/luisadha-patch-2/plugins/brandomusicv.alrc.plugin.sh

luisadha commented 2 months ago

reopen this issue please

VishnuSanal commented 2 months ago

@luisadha I didn't quite get you; what is the current issue that you are facing?

luisadha commented 2 months ago

@luisadha I didn't quite get you; what is the current issue that you are facing?

I mean, the app window disappears when the smartphone keyboard is idle (IME), it causes the app can't play the requested song via "xdg-open" or "am start -a android.intent.action.VIEW -d"

luisadha commented 2 months ago

@luisadha I didn't quite get you; what is the current issue that you are facing?

My project relies on apps like yours so I hope the app side of this issue can be resolved so I don't write "hide_soft_keyboard" in my project. Sorry for the trouble

VishnuSanal commented 2 months ago

@luisadha please create a new issue.