VishnuSanal / DialogMusicPlayer

A simple and minimal music player dialog :)
https://vishnusanal.github.io/posts/story-of-dialogmusicplayer/
GNU General Public License v3.0
82 stars 5 forks source link

While playing audio, changing the system theme causes the audio to stop playing. #51

Open sameemul-haque opened 1 year ago

sameemul-haque commented 1 year ago

Describe the bug

While playing audio, changing the system theme causes the audio to stop playing. Attempted to change the theme for the music player during audio playback by changing the system theme. The music player's theme successfully changed; however, I had to reopen the music player, and the audio playback was interrupted. Tested in two devices.

To Reproduce

  1. Play any audio using Dialog Music Player.
  2. Go to System Settings, and navigate to 'Display' or 'Themes.'
  3. Change the system theme to 'Dark' or 'Light.'
  4. Error: The audio stops playing.

Expected behavior

Audio playback should continue seamlessly even when changing the system theme.

Screenshots

Smartphone:

VishnuSanal commented 11 months ago

@sameemul-haque thank you for you descriptive bug report! this happens due to a workaround done to stop the music playing when the user quits the application. see: https://github.com/VishnuSanal/DialogMusicPlayer/blob/master/app/src/main/java/phone/vishnu/dialogmusicplayer/MainActivity.java#L222. there's no fix this this as of now 🙂