VishnuSanal / Quotes

Quotes Status Creator lets you share quotations as status images on social media
https://play.google.com/store/apps/details?id=phone.vishnu.quotes
GNU General Public License v3.0
50 stars 20 forks source link

Weird ACRA behaviour #75

Closed VishnuSanal closed 2 months ago

VishnuSanal commented 2 years ago

ACRA doesn't capture the error when the crash happens for the first time. It only captures from the second time. If the app is cleared from recents and opened again, the same behavior repeats.

I assume this has something to do with ACRA not getting initialized when the first crash happens. Maybe, I'm missing something silly!

Crash reporting works for now, but not completely. Only recurring crashes can be captured as of now.

Any help will be appreciated. Thanks!

IzzySoft commented 2 years ago

Speaking of which: ACRA changed its behaviour. In the past it was opt-in by default, now it is sending silent reports without asking the user's consent. Can you please check how you've configured it? Will the user be asked?

IzzySoft commented 2 years ago

@VishnuSanal can you give a short status message on this? I'm not a dev, but if I read the code correctly, reports will only be sent if the user actively presses a button deciding whether the report should go via Telegram or via Github. Can you confirm that? So no other "silent reports behind the user's back"?

VishnuSanal commented 2 years ago

@IzzySoft Yes.

The user should click the button for the report to be sent.

(and very sorry for the delay, was lil caught up & wanted to check their docs thoroughly before replying to you - just to be sure!)

IzzySoft commented 2 years ago

Thanks! Especially for making sure (delay gladly accepted for that). Whitelisted then, so no Anti-Feature will be raised :smiley: :partying_face:

shuvashish76 commented 2 years ago

Can we add our own custom crash reporter as mentioned by AppManager (AM) dev here: https://github.com/MuntashirAkon/AppManager/issues/289#issuecomment-782571555

AM consider ACRA as Tracker since it phone home by default.

VishnuSanal commented 2 years ago

@shuvashish76 Sure, will look into it.

since it phone home by default.

Didn't get you...?

shuvashish76 commented 2 years ago

https://wikiless.org/wiki/Phoning_home?lang=en As Izzy mentioned ACRA by default send reports silently i.e. without users' knowledge & consent.

IzzySoft commented 2 years ago

@VishnuSanal see here – default behavior of ACRA now is sending silent crash reports – i.e. the user is not asked for consent and not even informed about the fact, (crash) reports are simply sent in the background unless you explicitly specify differently in your code. Scanners can detect the presence of ACRA automatically, but not the configuration – hence ACRA is now considered a tracker (also with my repo and F-Droid, though we can white-list it as we "serve" the app in question; AM just scans "some app" and cannot know about the background, so it will always yield the warning).

VishnuSanal commented 2 years ago

@IzzySoft

@VishnuSanal see here – default behavior of ACRA now is sending silent crash reports –

Yes, saw that!

i.e. the user is not asked for consent and not even informed about the fact, (crash) reports are simply sent in the background unless you explicitly specify differently in your code.

I wonder where or how this gets sent (in the case of Quotes). I use a custom sender that opens an activity where the error is displayed to the user. Then, as you mentioned previously, the user can choose to ignore it or to send it by pressing one of the two buttons provided (GItHub & Telegram). I assume the role played by ACRA ends where it opens ACRAErrorActivity since sending is handled by the app itself.

Scanners can detect the presence of ACRA automatically, but not the configuration – hence ACRA is now considered a tracker (also with my repo and F-Droid, though we can white-list it as we "serve" the app in question; AM just scans "some app" and cannot know about the background, so it will always yield the warning).

Please correct me whether my assumption above is wrong, or kindly white-list Quotes from the warning ;)

Thanks!

IzzySoft commented 2 years ago

unless you explicitly specify differently in your code

I use a custom sender that opens an activity

I'd say a "custom sender" qualifies as "explicitly specifying differently", wouldn't you agree? So we're back at the point where I was saying I see no need to remove ACRA entirely – unless you want to make sure no scanner reports it erroneously as "tracking!" because it just looks at the "signature" (like AM which was named above, as it cannot have a "negative list" for all apps).

or kindly white-list Quotes from the warning

See above – done already 3 days ago :smiley:

VishnuSanal commented 2 years ago

I'd say a "custom sender" qualifies as "explicitly specifying differently", wouldn't you agree?

Yups, agreed. My bad!

or kindly white-list Quotes from the warning

See above – done already 3 days ago :smiley:

:D thanks