Vishvajeet590 / CowinPy-Andy

MIT License
1 stars 0 forks source link

Constant polling loop ends #9

Open RonakTotla opened 3 years ago

RonakTotla commented 3 years ago

Once the constant polling hits the restricted number of attempt count, it gives out the error showing too many attempts. But it does not keeps on trying till it is allowed again to start polling, as opposed to the bombardier code. It just give a buzzer beep and stops with the error message display. Is it meant to be that way? Shouldn't it be continuously polling? Although user has to enter the OTP manually, but if auto-OTP reading and continuous trials are enabled, the developer version could be it.

Vishvajeet590 commented 3 years ago

Can you post screenshot of that issue. I'll fix it ASAP.

RonakTotla commented 3 years ago

Will do on next instance. I accidentally closed the app.

RonakTotla commented 3 years ago

1 Here once the error occurs, the script asks permission to retry. I feel like it should be a default yes and it should keep on trying to generate new OTP and then auto read it too.

RonakTotla commented 3 years ago

The latest from bombardier script took care of it before the token was invalid though. If the same can be applied here, the script will be fully automated. Thoughts @Vishvajeet590

Vishvajeet590 commented 3 years ago

The latest from bombardier script took care of it before the token was invalid though. If the same can be applied here, the script will be fully automated.

At the start of this project, I deliberately left that on the User to retry or not as I thought if we constantly request for new OTP there might be some problem like soft block (Which is implemented by Cowin currently). I'll look into how @bombardier-gif has implemented it.

RonakTotla commented 3 years ago

Need to go through all the updates from bombardier script. They've got all the latest know-hows covered

RonakTotla commented 3 years ago

The latest from bombardier script took care of it before the token was invalid though. If the same can be applied here, the script will be fully automated.

At the start of this project, I deliberately left that on the User to retry or not as I thought if we constantly request for new OTP there might be some problem like soft block (Which is implemented by Cowin currently). I'll look into how @bombardier-gif has implemented it.

Yup