VishwaiOSDev / Loadify-iOS

Instant YouTube and Instagram video downloader for iOS.
https://vishwaiosdev.notion.site/Loadify-355a7be3509149e68bbc6b2a4eab88c6
MIT License
50 stars 16 forks source link

Feature: paste from clipboard button in URL View #27

Closed jimjimrao closed 8 months ago

jimjimrao commented 8 months ago

Description

Implemented a paste from clipboard button in the URLView to make it easier to add URLs.

Screenshots

Before After

Notes to Reviewers

I was using this on my own and thought it would be more convenient to add a button to paste from the clipboard instead of holding down the text field box and waiting for the paste option to come up. Let me know if this makes it easier for anyone else. I enjoyed using your app @VishwaiOSDev !

VishwaiOSDev commented 8 months ago

Hi @jimjimrao

Thank you for your contribution and for sharing the details about the paste from clipboard feature. I appreciate your effort in implementing it. I've reviewed the changes and the UI design you've shared. It looks good!

Screenshot 2024-01-03 at 11 31 54 PM

I've already designed the paste board UI as per Loadify Design preferences. I've used the doc.on.clipboard SF Symbol when the videoURL is empty and switched to the xmark.circle.fill symbol when it's not. Please update your code to match this UI, and if it all checks out, you can merge it into the main branch. Let me know if you have any more suggestions or tweaks in mind.

Looking forward to your feedback.

Thank you for your collaboration.

jimjimrao commented 8 months ago

Hey @VishwaiOSDev, I like your design. I will give that a shot and let you know if I run into any issues.

jimjimrao commented 8 months ago

@VishwaiOSDev I've implemented the changes to match your design and updated the screen recording. Let me know what you think.

jimjimrao commented 8 months ago

Thanks for the feedback @VishwaiOSDev. Just learning started learning Swift not too long ago so I use chatGPT on the side when I don't know something. This resulted in making it more complicated than it should have been.

I refactored the code in the way you proposed. Let me know if it looks good.

VishwaiOSDev commented 8 months ago

Thank you very much @jimjimrao