search

VisionEval / VisionEval-Dev

Development version of VisionEval framework
https://visioneval.github.io/
Apache License 2.0
6 stars 32 forks source link

Proposed check for Rtools on Windows #117

Closed dflynn-volpe closed 4 years ago

dflynn-volpe commented 4 years ago

Hadn't yet installed Rtools on this machine (recently new), so adding this check to notify others with potentially same issue.

@jrawbits This works as expected on my Windows machine (exits ve.build with an informative error if rtools not found), please take a look and see if this works for you.

jrawbits commented 4 years ago

Since this is code that will generally only run from within RStudio, it might be simpler to do this:

          if ( ! pkgbuild::has_build_tools() ) {
            stop('Please install Rtools for Windows, and make sure it is available in the system PATH. \n https://cran.r-project.org/bin/windows/Rtools/')
          }

Of course, that requires "pkgbuild" to be available for people who are not running RStudio, so it would need to be added to ve-lib. I'll play around with it...

dflynn-volpe commented 4 years ago

@jrawbits _Msg won't work, can't name an object in R with a leading _

Error: unexpected input in "_"

jrawbits commented 4 years ago

Fixed in the next update sequence.