VisionEval / VisionEval-Dev

Development version of VisionEval framework
https://visioneval.github.io/
Apache License 2.0
6 stars 32 forks source link

Makefile reset/clean scripts fail when path to built contains shell special characters #138

Closed jrawbits closed 2 years ago

jrawbits commented 3 years ago

There are a variety of lines like rm -rf $(VE_LOGS)/*.log in the VE Makefile that are used to clean up build artifacts.

Those will fail when the path includes spaces or special shell characters. Those instructions will be changed to wrap the variable expansion in double quotes, perhaps like rm -rf "$(VE_LOGS)"/*.log which seems to work adequately on a first try.

The workaround is to do the build in a directory with /simple/path/elements.

jrawbits commented 2 years ago

Appears to be working...