search

VisionEval / VisionEval-Dev

Development version of VisionEval framework
https://visioneval.github.io/
Apache License 2.0
6 stars 32 forks source link

Description of ElecDvmtProp in AssignHhVehiclePowertrain Module #151

Closed shichenfan closed 2 years ago

shichenfan commented 3 years ago

In the code and documentation VE_Training.md & Modules_and_Outputs.md , the description of outcome 'ElecDvmtProp' is ‘Average miles of vehicle travel per gasoline equivalent gallon (fuel and electric powered)’. It seems should be "Proportion of DVMT powered by electricity".

jrawbits commented 3 years ago

I'll make that description change in the development branch: it's just a description problem (incomplete cut-and-paste in creating the variable specification). Two places:

VETravelPerformance:::AdjustHhVehicleMpgMpkwh.R : line 371 (plus add more specific description of algorithm to module docs at the top of the file) VEPowertrainsAndFuels::AssignHvVehiclePowertrain.R: line 575 (plus module docs at top of file, change "ElecProp" in pseudo-code description to "ElecDvmtProp")

New description will be as Shichen proposes. We will need to change the secondary documentation as well.