VisionEval / VisionEval-Dev

Development version of VisionEval framework
https://visioneval.github.io/
Apache License 2.0
6 stars 32 forks source link

Indexing error in VELandUse::PredictHousing.R ipf function #157

Closed jrawbits closed 2 years ago

jrawbits commented 3 years ago

In VELandUse::PredictHousing.R, the ipf function has a helper function intended to sweep out zeroes in the seed matrix, replacing them with a very tiny value (1e-6) so the zero cells can still receive tiny values. Due to an indexing error (x=0 versus x==0), the function does nothing and zeroes remain untouched in the seed matrix.

Because this bug has the potential to change the resulting fitted matrix (and potentially change the model results perceptibly), I'm not just pushing it straight into development. We'll need to build the fix and compare results with a seed matrix that contains zeroes and see how much the key metrics change...