search

VisionEval / VisionEval-Dev

Development version of VisionEval framework
https://visioneval.github.io/
Apache License 2.0
6 stars 32 forks source link

VETravelDemandMM Build irregularity #192

Closed jrawbits closed 1 year ago

jrawbits commented 1 year ago

When starting a fresh build (using the Makefile or ve.build()), the VETravelDemandMM module fails to build due to a namespace inconsistency. The build crashes, but simply re-running it again (without resetting) then works. It appears to be a Namespace problem with the Namespace stored in the Github. With the other modules, the namespace is not saved and is instead regenerated on each build. The VETravelDemandMM uses a different Roxygen strategy than the other modules (which just run the R scripts). We need to make this module build correctly in one pass of ve.build (like the other moduels).

Rather than tackle this issue now, we'll wait until Oregon DOT / RSG are done updating VETravelDemandMM. Simple workaround is just to launch the build again after it crashes (then it all works).

jrawbits commented 1 year ago

Should be fixed in R 4.2.2 release; it wasn't just a Roxygen build-method problem, but also related to sequencing of the namespace construction, etc.

jrawbits commented 1 year ago

Fixed in development-next 2023-03-24