VisionEval / VisionEval-Dev

Development version of VisionEval framework
https://visioneval.github.io/
Apache License 2.0
6 stars 32 forks source link

Scenario Management Updates #92

Closed DavidOry closed 4 years ago

DavidOry commented 4 years ago

Three changes:

jrawbits commented 4 years ago

A couple of issues.

First, still haven't addressed Shichen Fan's previous comment: After line 49 of scenario_management_vignette.Rmd, add: dir.create(new_json_file_dir)

Generally, the vignette needs to be cleaned up and reconciled with actually loading and running this item as a tool.

Internally, using the "import" package to install this "tool" does not allow you to use "library" calls. You have to reach objects through namespaces, which includes the magrittr pipe operator. Using the "assign/getFromNamespace" hack I did before works.

Also, the .html vignette file needs to be regenerated.

jrawbits commented 4 years ago

see the curent "scenario-mgmt" branch in VisionEval-dev where I merged all this.

jrawbits commented 4 years ago

Merging this pull request into the scenmgmt branch. Will update with any remaining issues once compile/test vignette is complete. Adjusted to make the code a full-blown tool, and also gave the user instructions to rebuild the .Rmd -> .html vignette.