search

VisionSystemsInc / terra

Terra - Run your algorithm anywhere on earth
MIT License
0 stars 3 forks source link

remove leading underscore from lock_counter member #152

Closed decrispell closed 1 year ago

decrispell commented 1 year ago

I haven't yet figured out why this change is needed for me - Perhaps the API of the filelock library changed recently? I have filelock version 3.12.0, Python 3.10.11

decrispell commented 1 year ago

https://py-filelock.readthedocs.io/en/latest/api.html#filelock.BaseFileLock.lock_counter

scott-vsi commented 1 year ago

Hmm, ya

https://github.com/tox-dev/py-filelock/commit/b4713c946cf8bcd65276bffbccef8f269d504dbd

The bigger question is why do you have v3.12.0. The Pipfile.lock says 3.10.2

decrispell commented 1 year ago

My project uses terra as a submodule/editable dependency and has its own Pipfile.lock, which does say 3.12.0. If terra wants to ensure an older version of filelock is installed I think it would have to specified in the requirements (setup.py or pyproject.toml), not the Pipfile / Pipfile.lock

scott-vsi commented 1 year ago

Ya. I guess we should set a version limit on filelock in the setup.py file

decrispell commented 1 year ago

Closing this PR because it would require updating terra's Pipfile, Pipfile.lock, which is not desirable. Instead, users of terra should make sure that their version of lockfile is < 3.12