search

VisionSystemsInc / terra

Terra - Run your algorithm anywhere on earth
MIT License
0 stars 3 forks source link

Improve experience with default settings. #87

Closed NoahRJohnson closed 3 years ago

NoahRJohnson commented 3 years ago

The Terra controller already takes up one process. Account for that in the default number of processes you spawn for tasks. Minimize memory thrashing!

andyneff commented 3 years ago

But the terra controller should be mostly idle, this change also doesn't make sense for works on other nodes.

Also, it's typical go over the # of cores a little, since a core is often 95% utilized, and you might want to try to get that extra 4-5%.

Do you have a use case where this is actually make a difference? I would suspect something else is going on.

NoahRJohnson commented 3 years ago

No use case, I was just thinking about this hypothetically. This change only applies to ProcessPoolExecutor (and ThreadPoolExecutor), but that is the default executor type. If you think it's fine as-is (specifically in the case of StereoDSMGeneration) then I'm ok with declining this PR.