search

Visual-Regression-Tracker / agent-codeceptjs

3 stars 2 forks source link

"options" should be optional when running "vrtTrack" #27

Open ngraf opened 3 years ago

ngraf commented 3 years ago

https://github.com/Visual-Regression-Tracker/agent-codeceptjs/blob/3891780ff922b7c21cb998f6fba699b1c8295a89/lib/index.ts#L41

Why "options" is mandatory? Please make it optional, so that Typescript linting is not complaining. Why I have this expectation? Because in the README.md an example is given where no option is passed to vrtTrack and because I personally also think it makes sense to make it optional when there is no reason to make it mandatory.

pashidlos commented 3 years ago

@ngraf good point! would you like to contribute with the fix?

ngraf commented 3 years ago

No, sorry. I am not a good developer. I am just a passionate QA/user of the agent.