search

Visual1mpact / Paradox_AntiCheat

A utility to fight against malicious hackers on Bedrock Edition.
GNU General Public License v3.0
35 stars 22 forks source link

made chat filter able to be disabled #15

Closed Dreamedc2015 closed 2 years ago

Visual1mpact commented 2 years ago

Unfortunately, this change won't work. It's in the right direction but needs to be handled differently. Disabling the function for ChatFilter will subsequently break the ability for staff to tag their names using the command !tag . Inside the function for ChatFilter it has a hard implementation for filtering the messages being broadcasted. The filter will need to be extracted from that function and isolated elsewhere. I suggest making it into a module using the current module in this patch and mimicking the module for namespoofB for "regex" but an implementation that offers the module control over enabling or disabling it.

Dreamedc2015 commented 2 years ago

making it configurable isnt actually a bad thing. people may not even want the option to be tagged

also "chat filter" isnt a really good way to name the thing which does your nicks

Visual1mpact commented 2 years ago

They are two separate features built into one single concept. Blocking both for one isn't feasible. Needs to be isolated to be considered. So that both are available.

Visual1mpact commented 2 years ago

Closing this pull request since it is inadequate as is and no changes have been made since the initial request.