search

VisualAppeal / Matomo-PHP-API

PHP wrapper for the Matomo API.
MIT License
95 stars 33 forks source link

[!!!] Breaking: Add more parameters to SitesManager.addSite #40

Closed simonschaufi closed 6 years ago

simonschaufi commented 6 years ago

Add settingValues and excludeUnknownUrls to addSite and sync them with the official Piwik API. Beware of new parameter order!

simonschaufi commented 6 years ago

phpunit/phpunit 6.4.4 requires php ^7.0 -> your PHP version (5.6.31) does not satisfy that requirement.

Should I downgrade phpunit again?

thelfensdrfer commented 6 years ago

Thanks for your work! You can add php >= 7 as a requirement in the composer.json file. Should be fine. I will create a new minor release for this pull request anyways.

simonschaufi commented 6 years ago

done. HHVM still breaks. See also this issue: https://github.com/composer/composer/issues/4976 Anyway, I have added it to the allow_failures list.

Btw, how did you create your avatar?

thelfensdrfer commented 6 years ago

I've used avatarmaker.com or some similar service ;)