VisualAppeal / Matomo-PHP-API

PHP wrapper for the Matomo API.
MIT License
95 stars 33 forks source link

Can you make the _request() function public instead of private #6

Closed michaelmohamed closed 9 years ago

michaelmohamed commented 9 years ago

By having the _request function private, i cannot use it in another class to make custom api calls.

e.g:

class myClass {

    function __construct(  $site = '', $token = '', $site_id = '' ) {

        $this->piwik = new \Piwik( $site, $token, $site_id);

        $this->piwik->_request( 'API.getPiwikVersion' );

    }

}

Thank You!

thelfensdrfer commented 9 years ago

It would be nice to implement the missing possible requests instead of setting the request to public. Or are there possible requests, e.g. for plugins?

thelfensdrfer commented 9 years ago

Any thoughts @echo1consulting ?

thelfensdrfer commented 9 years ago

I will close this issue for now. Please feel free to comment or reopen if you have any details!