search

VisualComposer / visual-composer-starter

Visual Composer Starter theme for WordPress designed to be a perfect companion for a simple and good looking website or blog.
https://visualcomposer.com/visual-composer-starter-theme/
GNU General Public License v2.0
135 stars 61 forks source link

Visual Composer Starter Theme fails with PHP 7.3 #274

Closed wallyxplor closed 4 years ago

wallyxplor commented 4 years ago

When attempting to log into (my) Wordpress site, the normal login page (using 'site url'/wp-admin) does not appear. Instead the following error message appears:

"Warning: Cannot modify header information - headers already sent by (output started at /home/++++++/public_html/wp-content/themes/visual-composer-starter-child/functions.php:2) in /home/++++++/public_html/wp-includes/pluggable.php on line 1265"

(where ++++++ is the site's specific directory) This happens only with PHP 7.3 active and VC Starter theme 3.0.3. There is no problem viewing or logging in when PHP 7.1 is active. My hosting provider recommends PHP 7.3 (more secure) and wondered if an update for the theme of the site was available. Sadly, no - not at this time.

A visual-composer-starter theme update that works with PHP 7.3 would be welcome.

alperbuulut commented 4 years ago

Hi,

We could not replicate the issue with checking PHP 7.3 and VC Starter theme 3.0.3. It is working properly with these versions. Maybe, there might be a problem with your child functions.php as you can see in the error messages. Otherwise, you can share more details with us to replicate the issue. You can follow our bug reporting steps linked below.

https://github.com/VisualComposer/visual-composer-starter/blob/master/.github/ISSUE_TEMPLATE/bug_report.md

Thanks for reporting!

wallyxplor commented 4 years ago

Hello Alper, Thank you for your quick check and reply. Of course you tested PHP 7.3 with the actual VC Starter theme, not the child theme code I have. I took your idea about my child theme code being the problem. I compared my functions.php code with some examples on wordpress.org ... and made a couple minor changes. With the new functions.php (child theme) - PHP 7.3 WORKS! With that in mind, do I need to add the fact the theme is now working on the Github site - or is this email enough?

Thanks again, Walter

On Thu, Mar 12, 2020 at 6:18 AM Alper Bulut notifications@github.com wrote:

Hi,

We could not replicate the issue with checking PHP 7.3 and VC Starter theme 3.0.3. It is working properly with these versions. Maybe, there might be a problem with your child functions.php as you can see in the error messages. Otherwise, you can share more details with us to replicate the issue. You can follow our bug reporting steps linked below.

https://github.com/VisualComposer/visual-composer-starter/blob/master/.github/ISSUE_TEMPLATE/bug_report.md http://url

Thanks for reporting!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/VisualComposer/visual-composer-starter/issues/274#issuecomment-598109821, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHJFVCNBNQWCBSWFKGCALU3RHCZIDANCNFSM4LFNJ64A .

--

Walter Bubie Lecturer/ Faculty - UX/UI Design Rochester Institute of Technology / NTID www.rit.edu/wcbics-walter-bubie

alperbuulut commented 4 years ago

Hello Walter, No need to do anything for now. We will close the issue. If you have any further issue, feel free to report us.

Thank you!