search

VisualComputingInstitute / Beacon8

A Torch-inspired library for high-level deep learning with Theano.
MIT License
5 stars 0 forks source link

Factor out progress-bar to examples.utils. #14

Closed lucasb-eyer closed 9 years ago

lucasb-eyer commented 9 years ago

This also adds a fallback text-only "progressbar" in case the progressbar library is not available.

For example, I can't pip install it because of some (probably python version related) issue which I don't want to investigate now.

Note that it also corrects j to j+1 in training progress.

lucasb-eyer commented 9 years ago

Also, do you still have a python2 setup where you could test it? I'm not totally sure the from examples.utils import make_progressbar works in python2?

lucasb-eyer commented 9 years ago

Oh and note that I called the file utils.py as I have a bit more in there that I will make PRs for in the near future.

ikostrikov commented 9 years ago

For python3 it can be installed either manually or with apt-get install python3-progressbar . But anyway I like your solution:). Is it ready to merge or you want to change something else?

lucasb-eyer commented 9 years ago

Nothing more to add, it works fine here so you can merge, but as I said I can't test on py2.

ikostrikov commented 9 years ago

Ok. Then I will test it tomorrow evening and merge then.

ikostrikov commented 9 years ago

Sorry, but I have to shift testing to Friday. I will test and merge.

lucasb-eyer commented 9 years ago

No stress :)

lucasb-eyer commented 9 years ago

Being back at home, I could test in a py2 env with and without progressbar installed. As I guessed, there was a problem with the import in py2, which I fixed this way, according to PEP366.

Since I have now tested it everywhere and there weren't any more objections from your side besides testing, I'll merge this later today and you can reopen this issue if there's problems.