search

VisualNeuroscience-UH / CxSystem2

Version 2 of the cortex simulation software.
https://cxsystem2.readthedocs.io
MIT License
4 stars 1 forks source link

Grid_radius is not grid radius? #50

Closed henhok closed 4 years ago

henhok commented 5 years ago

Looking at cell positions in this example with grid_radius set to 210 um makes me wonder what is grid_radius actually referring to... If it was radius, then min+max = ~420 um. If it was diameter, then min+max = ~210 um. Right?

grid_radius

Vafa-Andalibi commented 5 years ago

@sivanni can you check this and confirm whether this is a bug?

sivanni commented 5 years ago

210 microm was the radius in Markram model, in above example it is diameter

Hanki Outlook for Androidhttps://aka.ms/ghei36

From: Vafa Andalibi notifications@github.com Sent: Friday, October 18, 2019 7:04:44 PM To: VisualNeuroscience-UH/CxSystem2 CxSystem2@noreply.github.com Cc: Vanni, Simo H simo.vanni@helsinki.fi; Mention mention@noreply.github.com Subject: Re: [VisualNeuroscience-UH/CxSystem2] Grid_radius is not grid radius? (#50)

@sivannihttps://github.com/sivanni can you check this and confirm whether this is a bug?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/VisualNeuroscience-UH/CxSystem2/issues/50?email_source=notifications&email_token=ADVCKY2BJ6J7HLFCO4OB2ZTQPHNBZA5CNFSM4JCIRHTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBU6T7I#issuecomment-543812093, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADVCKYYBACJHNEWIW4YT3XLQPHNBZANCNFSM4JCIRHTA.

sivanni commented 5 years ago

Thus I think it might be a bug

henhok commented 4 years ago

My bad! Cell positions are stored in w_positions, not z_positions as shown in the picture above. z_positions correspond to retinal locations. I fixed visimpl conversion code and added comments to the code.