VisualPinball / VisualPinball.Engine.PinMAME

PinMAME support for VPE
MIT License
2 stars 1 forks source link

misc: remove internal id. #26

Closed jsm174 closed 2 years ago

jsm174 commented 2 years ago

This PR is a companion to https://github.com/freezy/VisualPinball.Engine/pull/408

It removes the InternalId parameter that is no longer part of switches, lamps, and coils.

A new class PinMameIdAlias was created to associate an integer PinMAME id to a VPE string id. All games and MPUs were updated to support having aliases. For example:

https://github.com/VisualPinball/VisualPinball.Engine.PinMAME/blob/dbda3c83e5ac65aba0ea16cde64f024a9e404bd9/VisualPinball.Engine.PinMAME/MPUs/Wpc.cs#L35-L51

Dictionaries that map PinMAME ids to aliases, and aliases to PinMAME ids have been created to allow for fast lookup.

Note: Any existing projects should have the switches, coils, and lamps refreshed. Single digit PinMAME ids were probably two characters (01, 02, 03), and are now single characters (1, 2, 3).

To Do: