It removes the InternalId parameter that is no longer part of switches, lamps, and coils.
A new class PinMameIdAlias was created to associate an integer PinMAME id to a VPE string id. All games and MPUs were updated to support having aliases. For example:
Dictionaries that map PinMAME ids to aliases, and aliases to PinMAME ids have been created to allow for fast lookup.
Note: Any existing projects should have the switches, coils, and lamps refreshed. Single digit PinMAME ids were probably two characters (01, 02, 03), and are now single characters (1, 2, 3).
To Do:
[ ] should there be a UI for defining / viewing PinMameIdAlias?
[X] Manager lists are sorted by ID. Is 1, 10, 11, 12 an issue? (See note above) - Fixed sorting in ManagerListView.cs
This PR is a companion to https://github.com/freezy/VisualPinball.Engine/pull/408
It removes the
InternalId
parameter that is no longer part of switches, lamps, and coils.A new class
PinMameIdAlias
was created to associate an integer PinMAME id to a VPE string id. All games and MPUs were updated to support having aliases. For example:https://github.com/VisualPinball/VisualPinball.Engine.PinMAME/blob/dbda3c83e5ac65aba0ea16cde64f024a9e404bd9/VisualPinball.Engine.PinMAME/MPUs/Wpc.cs#L35-L51
Dictionaries that map PinMAME ids to aliases, and aliases to PinMAME ids have been created to allow for fast lookup.
Note: Any existing projects should have the switches, coils, and lamps refreshed. Single digit PinMAME ids were probably two characters (
01
,02
,03
), and are now single characters (1
,2
,3
).To Do:
PinMameIdAlias
?1
,10
,11
,12
an issue? (See note above) - Fixed sorting in ManagerListView.csConcat
method: https://github.com/VisualPinball/VisualPinball.Engine.PinMAME/blob/b413449e23a24584d15e9e76812017244eb11a79/VisualPinball.Engine.PinMAME/PinMameGame.cs#L103Concat
method: https://github.com/VisualPinball/VisualPinball.Engine.PinMAME/blob/b413449e23a24584d15e9e76812017244eb11a79/VisualPinball.Engine.PinMAME/PinMameGame.cs#L118PinMameMechConfig
https://github.com/VisualPinball/VisualPinball.Engine.PinMAME/blob/dbda3c83e5ac65aba0ea16cde64f024a9e404bd9/VisualPinball.Engine.PinMAME.Unity/Runtime/PinMameMechComponent.cs#L82VisualPinball.Engine.PinMAME.csproj
back to