search

VisualReCode / Cocoon

An implementation of the Strangler Fig pattern for ASP.NET Core
Apache License 2.0
62 stars 10 forks source link

GitHub Action for PR is failing with missing VS 2019 installation #24

Closed conficient closed 2 years ago

conficient commented 2 years ago

I updated a pull request #27 to update the YARP library to version 1.0.1 (to include security fix). The GitHub Action to build the PR is failing when trying to execute a VS2019 build: https://github.com/VisualReCode/Cocoon/runs/6097402981?check_suite_focus=true#step:8:1

conficient commented 2 years ago

Looked at the GitHub Action docs - I think the windows-latest has now transitioned to VS2022.

If the runner is downgraded to windows-2019 I think this should fix the build script.

Update: confirmed this: the windows-latest runs on with VS2022 included, and the windows-2019 runner has VS2019.

conficient commented 2 years ago

@markrendle or @TheRubble please can you update - or if you wish to make me a co-contributor I'll fix these issues myself. Cheers!

conficient commented 2 years ago

Fixed in latest main release