search

Visualyticai / DigitalOnboard_Spoof

0 stars 0 forks source link

Review changes for DOT-1 please NOW UPDATE changes in DOT-6 #2

Open visualyticsai opened 3 years ago

visualyticsai commented 3 years ago

  1. why your main file is in test folder remove it from there and put it in main directory.

  2. use snake casing

  3. as you know the results of each image in tests so please use assertions.

  4. While pip installation getting this error:

    ERROR: Could not find a version that satisfies the requirement sklearn==0.23.2 (from -r requirements.txt (line 8)) (from versions: 0.0)
ERROR: No matching distribution found for sklearn==0.23.2 (from -r requirements.txt (line 8))

  5. Please mention your Python version in requirements file like below

    python.version = "whatever version you are using"

  6. running python app.py gives following error,

    2020-12-07 22:47:38.967834: W tensorflow/stream_executor/platform/default/dso_loader.cc:59] Could not load dynamic library 'libcudart.so.10.1'; dlerror: libcudart.so.10.1: cannot open shared object file: No such file or directory
2020-12-07 22:47:38.967873: I tensorflow/stream_executor/cuda/cudart_stub.cc:29] Ignore above cudart dlerror if you do not have a GPU set up on your machine.
Traceback (most recent call last):
File "app.py", line 1, in <module>
from Test.Face_reality import check_reality
File "/home/owais/visualytics/DigitalOnboard_Spoof/Test/Face_reality.py", line 15, in <module>
net = cv2.dnn.readNetFromCaffe(os.getcwd() + "/face_detector/deploy.prototxt", os.getcwd() + "/res10_300x300_ssd_iter_140000.caffemodel")
cv2.error: OpenCV(4.4.0) /tmp/pip-req-build-cg56sov1/opencv/modules/dnn/src/caffe/caffe_io.cpp:1121: error: (-2:Unspecified error) FAILED: fs.is_open(). Can't open "/home/owais/visualytics/DigitalOnboard_Spoof/face_detector/deploy.prototxt" in function 'ReadProtoFromTextFile'
D3nii commented 3 years ago

Done! https://github.com/Visualyticai/DigitalOnboard_Spoof/tree/DOT-6

visualyticsai commented 3 years ago

In https://github.com/Visualyticai/DigitalOnboard_Spoof/tree/DOT-6.

  1. Why there are two test folders ?
  2. Use '#' sign in requirements.txt for python version, as mentioned above.
  3. In class CheckReality, use snake case for ReturnLabel because its function not class.
  4. Also, create PR for DOT-6 and share with me for review.
D3nii commented 3 years ago

@visualyticsai We would discuss the test folder duplicate issue in the meeting, to try and delete it, I even deleted the whole DOT-6 branch and recreated it later but nah.

Also, other issues are resolved!