search

Vita-App / Vita

Bringing life back to your college life.
https://mentorship.thapar.edu/
MIT License
120 stars 78 forks source link

added backend route for fetching topic data #153

Closed Icelain closed 2 years ago

Icelain commented 2 years ago

Route is: /api/get-topics. Partially improves #152

github-actions[bot] commented 2 years ago

Our team will soon review your PR. Thanks @Icelain :)

Lalit3716 commented 2 years ago

The endpoint looks okay! but I was thinking if you could fetch the topics data from the MongoDB database?

Icelain commented 2 years ago

The endpoint looks okay! but I was thinking if you could fetch the topics data from the MongoDB database?

Oh yeah I was wondering about that. Didn't know earlier but thanks for the confirmation. I'll work on it.

Icelain commented 2 years ago

hey I made the changes. Is it okay?

Lalit3716 commented 2 years ago

Yeah, it looks good but it would be great if you could paginate the response. You can see this controller for reference.

Icelain commented 2 years ago

I made the limit 0 by default :)

Lalit3716 commented 2 years ago

LGTM 🎉

github-actions[bot] commented 2 years ago

Thank you @Icelain for taking out your valuable time in order to contribute to our project. Looking forward for more such amazing contributions :).