search

Vita-App / Vita

Bringing life back to your college life.
https://mentorship.thapar.edu/
MIT License
120 stars 78 forks source link

Copy room link on click #70

Closed yahya-cloud closed 2 years ago

yahya-cloud commented 2 years ago

Hello, As earlier there was no option to copy video chat link on click. Now instead of making an another button, i added the copyLink function to Label onClick event listener, also made the label cursor pointer.

netlify[bot] commented 2 years ago

Deploy Preview for vitaa-app ready!

Name Link
Latest commit f0f6460d81389a3708da5405781b88d466d6fed5
Latest deploy log https://app.netlify.com/sites/vitaa-app/deploys/6242b6859e46850008242e7d
Deploy Preview https://deploy-preview-70--vitaa-app.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions[bot] commented 2 years ago

Our team will soon review your PR. Thanks @yahya-cloud :)

Sahaj-Srivastava24 commented 2 years ago

Hey @yahya-cloud, Your work looks good to me. Can you add a snackbar notification that pops up when the link is copied? You can look at MUI Snackbar to see how snackbars work.

yahya-cloud commented 2 years ago

Hello @Rishabh-malhotraa , yes sure i will add it and can you please add GGSOC label to this pull request.

yahya-cloud commented 2 years ago

hello @Sahaj-Srivastava24, as i saw react-toastify was used in this project so added the toast function inside copy link function, instead of using mui snackbar. Now when we copy the link a toast appears of type success with text "Link copied" .

Lalit3716 commented 2 years ago

Sorry @yahya-cloud we decided to move Vita-Meet outside from our main app. So we couldn't merge this PR Hope you will understand! 😔

Though thanks for giving us your valuable time, we will look forward to see successful contributions from you!

github-actions[bot] commented 2 years ago

Thank you @yahya-cloud for taking out your valuable time in order to contribute to our project. Looking forward for more such amazing contributions :).