0xAtum
commented
4 months ago Your comments frequently include uncertain terms such as "as far as I know" and "I think." Are these expressions used because of uncertainty or as a writing habit ?
If uncertainty is the reason, please consult with your team for clarification.
Repo was called "staking-contract" because at first, it was presented to me as a staking one. But once I received the scope, it was including a vesting too. It is indeed confusing, but shouldn't be assumed that it means something wasn't asked due of the naming.
That being said, I removed it, as you mentioned, it is easy to recover if you need it.
As part of the cleanup, I suggest we remove the vesting folder. As far as I know, we're not planning to replace VitaDAO's current vesting contract. Plus also weird/confusing to have a vesting contract in a repo called "staking-contract". If we're not going to use it, it'll just be cruft. If we want to use it in the future, we could always recover it from Git history.