VitaDAO / staking-contract

MIT License
0 stars 0 forks source link

Merging contract interface and implementation files #4

Open raulrpearson opened 2 weeks ago

raulrpearson commented 2 weeks ago

I think it'd be better to have everything in a single file, as we don't seem to have the need to extend this interface in more than one place. I assume this is a common pattern in Solidity, but my impression is that mechanically splitting into two files out of habit just adds indirection/complexity and makes the code more difficult to understand.

0xAtum commented 2 weeks ago

Although it is true you normally don't create one if it's not used somewhere else. In solidity we assume someone might implement your contract in their side. So ideally, you should not remove it.

It also avoids having a bunch of comments, so we can still have a NatSpec without affecting the readability of the Core-Logic. Splitting non-logic from the logic itself.

I wouldn't recommend you to remove it.