VitaliiBlagodir / cordova-plugin-datepicker

MIT License
318 stars 350 forks source link

DatePickerDialog Holo styling failed on Android 7 Nougat #239

Open marcoramires opened 7 years ago

marcoramires commented 7 years ago

It's a know Nougat issue: https://stackoverflow.com/questions/39873076/datepickerdialog-holo-styling-failed-on-android-7-nougat

"... It turns out that Android 7.0 shipped with a bug: trying to use the Holo theme on this platform instead falls back to using a broken Material theme for the DatePickerDialog. See these two bug reports:"

https://issuetracker.google.com/issues/37120178 https://issuetracker.google.com/issues/37119315

Workaround by Jeff Lockhart: https://gist.github.com/jeffdgr8/6bc5f990bf0c13a7334ce385d482af9f

I will try to work on a fix and submit a pull request.

Cheers

lukeisontheroad commented 7 years ago

Were you already able to fix this? I didn't find it a pullrequest or a fix on your branch.

marcoramires commented 7 years ago

Hi @lukeisontheroad,

I didn't have the time to work on this yet.

As this bug is being fixed in the later version of Android (7.1.1) we decided to add a conditional statement for v7.0 users and use the default calendar instead.

e.g.

// HOLO theme calendar bug in Android 7.0
if(device.platform == 'Android' && device.version == '7.0') {
  var options = {
    androidTheme: 0
  };
}

It will solve our problems for now.

Cheers, Marco