search

Vitaliy-1 / JATSParser

JATSParser is aimed to be integrated with Open Journal Systems 3.0+ for transforming JATS XML to various formats
GNU General Public License v3.0
11 stars 20 forks source link

Anchor tags #8

Closed ohilbig01 closed 4 years ago

ohilbig01 commented 4 years ago

Hi Vitaly, I think you forgot the anchor tags to jump to the figures. In "./JATSParser/src/JATSParser/HTML/Figure.php", this works for me:

...        
    public function setContent(JATSFigure $jatsFigure) {

+               // anchor tags
+               $aNode = $this->ownerDocument->createElement("a");
+               $aNode->setAttribute("name", $jatsFigure->getId());
+               $this->appendChild($aNode);

...

Regards Olaf

Vitaliy-1 commented 4 years ago

Hi @ohilbig01,

Thanks! And I think the same applies and for tables too...

Nostrabramus commented 4 years ago

Hi, I this issue was fixed by this pull request: https://github.com/Vitaliy-1/JATSParser/commit/f08e661a605b8a273fa5bffb8dcfc06dfb8bcf22#diff-5669f618eee6c5209c0a2883f036496b

Vitaliy-1 commented 4 years ago

Thanks. Closing.