PDF conversion fails on empty tags

Vitaliy-1 / JATSParserPlugin

OJS3 Plugin for parsing JATS XML and displaying it on article detail page

GNU General Public License v3.0

27 stars 24 forks source link

PDF conversion fails on empty tags #43

Closed Vitaliy-1 closed 3 years ago

Vitaliy-1 commented 3 years ago

Tested on empty td elements inside tables. This fails silently, PDF is produced with the data converted before the error. Looks like TCPDF issue. Solution: remove empty tags before passing the document to the TCPDF

Vitaliy-1 commented 3 years ago

TCPDF doesn't support self-closed tags, which Texture may produce: <td id="39408c179c871244d29bb9046a8b8b7a"/>. Recent modifications with preparation of HTML before feeding it for PDF creation, passing it through PHP DOM, solves the issue by changing this into a proper form: <td></td>