Vitaliy-1 / JATSParserPlugin

OJS3 Plugin for parsing JATS XML and displaying it on article detail page
GNU General Public License v3.0
27 stars 24 forks source link

image cant display through jatsparser #72

Open waqas1223 opened 2 years ago

waqas1223 commented 2 years ago

Hi @Vitaliy-1 we are facing some issues with the display image. I do everything as much I can find relevant to this but failed. we are currently using. ojs : 3.2.10 PHP version 7.3.33 jatsparser : 2.1.9-2

here is what i do: upload dependent image file through submission file.

12

also, check from upload image file from texture. also add path >>> import('lib.pkp.classes.submission.SubmissionFile'); 123 at the end image file path changed 1234 one more thing reffernce cant shown in full text our website link: http://surgicalcompass.org/index.php/sc/article/view/148

Vitaliy-1 commented 2 years ago

one more thing reffernce cant shown in full text

References should be parsed separately, the option is under the References tab in Publication settings. Appears after successful parsing of full-text. download

we are facing some issues with the display image

Before moving into the problem deeper, can you double-check that the actual filename of the uploaded file corresponds to the one, pointed in the JATS XML file? Note, as far as I remember this is different behavior than in OJS 3.3, where the name of the file pointed in OJS (as per screenshot) should be the same as in XML. This is related to changes in the OJS File Manager.

waqas1223 commented 2 years ago

Yes, the dependent file name was the same in the XML file. Untitled

waqas1223 commented 2 years ago

sir reference part is showing on the website. but its reference tag is not clickable.

waqas1223 commented 2 years ago

Yes, the dependent file name was the same in the XML file. Untitled

hi there waiting for your response..

Vitaliy-1 commented 2 years ago

sir reference part is showing on the website. but its reference tag is not clickable.

For technical reasons, this is going to be available only from OJS 3.4

Regarding figures, I'm running OJS 3.2.1 instance with the JATS Parser Plugin version specified and cannot reproduce the problem there. Maybe the problem is in identifying MIME types of images being uploaded? When an image is uploaded, the data is saved in the submission_files table. Can you check the file_type column for those images?

waqas1223 commented 2 years ago

Hi there. sorry for late reply ... here is a screen shot. actually upload multiple file for testing propose . Screenshot_1

Vitaliy-1 commented 2 years ago

Looks good to me.

I've installed a clean instance with versions specified and still aren't able to reproduce the problem. On the front-end, the link with filename should be substituted with the real one, like:

http://localhost:8000/index.php/fj/article/downloadFullTextAssoc/1/3/4

where http://localhost:8000/index.php/fj is a path to the journal, article - path to the article landing page, downloadFullTextAssoc - operation/method of the Article Handler, 1 - submission ID, 3 - file ID of the original JATS XML file, to which the image is attached to and the last 4 - is file ID of the image.

I don't see another option than debugging this (downloadFullTextAssoc) operation and associated code.

Are you able to make a backup of the site and install it locally for debugging? This is where this link is constructed: https://github.com/Vitaliy-1/JATSParserPlugin/blob/stable-3_2_1/JatsParserPlugin.inc.php#L739. Can you debug this to find where it fails, e.g., by outputting variables in the PHP error log with error_log() function in different places of this foreach cycle: https://github.com/Vitaliy-1/JATSParserPlugin/blob/stable-3_2_1/JatsParserPlugin.inc.php#L733?

I recommend to use PHP built-in server instead of apache for simplicity: download and unpack OJS, import database, run php -S localhost:8000 from an OJS root (PHP should be installed on the system). Let me know if you need more details to debug this, e.g., if you don't have prior experience.

waqas1223 commented 2 years ago

Hi @Vitaliy-1 sorry for late reply actually try other lens for main problem. i think there is no problem in jatparser because i use embedGalley plugin but unfortunately image cant show there also. here is the link

http://www.archivessr.com/index.php/asr/article/view/144

what kind of problem is in your point of view revised thing

  1. in Xml file image indicate : image 1.jpeg
  2. also try with texture
  3. cpanel get exect image link
  4. try jatparser
  5. try embedGalley

kindly help me out of this problem.

Vitaliy-1 commented 2 years ago

Is the problem relevant only for images with filenames which contain spaces? E.g., does it work for image1.jpeg instead of image 1.jpeg? There is a known issue regarding spaces in filenames: https://github.com/pkp/pkp-lib/issues/5999

waqas1223 commented 2 years ago

Hi there @Vitaliy-1 we try both styles with space(in top image Xml link) and without space image names but. still cant get result in both parser jatsparser and embedGalley.