search

Vitaliy-1 / JATSParserPlugin

OJS3 Plugin for parsing JATS XML and displaying it on article detail page
GNU General Public License v3.0
27 stars 24 forks source link

generate PDF for an article with two or more versions #85

Open eddoff opened 1 year ago

eddoff commented 1 year ago

I tried to generrate PDF for an article that had two active versions (I am using OJS 3.3.0.13).

I was going to "fulltext" tab for the old version of the article, and tried to generate a PDF for that. However, no PDF was generated for this version. But when switching to the new version another PDF has been generated there instead. The metadata (issue name, year and number) from the new version appeard in the header of the PDF.

I hope you can solve this issue. We are publishing in an "online-first"-manner where the issue is changing from this online-first-issue to an archived version when the year has ended. So this issue affects all articles in the journal.

Best regards.

Vitaliy-1 commented 1 year ago

Thanks, @eddoff

Can you check if this commit fixes the issue: https://github.com/Vitaliy-1/JATSParserPlugin/commit/6a17ff5560f3b4409291395515465cf6e939368d?

eddoff commented 1 year ago

It does not seem to work, unfortunately.

Vitaliy-1 commented 1 year ago

@eddoff, this data is passed to the browser, make sure that the JS cache is cleared.

eddoff commented 1 year ago

I have cleared the cache both of the browser and OJS. The PDF is generated in the correct version now, but still the issue name and number of the other version of the article is included in the PDF.

Vitaliy-1 commented 1 year ago

but still the issue name and number of the other version of the article is included in the PDF

To fix this part, apply additionally this commit: https://github.com/Vitaliy-1/JATSParserPlugin/commit/7cb50cb78b373e9318a2318c1f6a6ac86c05741c

eddoff commented 1 year ago

Great, it works! Thanks! When do you plan to publish a new version of the plugin?

Vitaliy-1 commented 1 year ago

After new OJS release

eddoff commented 1 month ago

Is the plugin working in 3.4 yet? There is no release since 2020!