search

Vitaliy-1 / oldGregg

Theme for OJS 3 with Bootstrap 4
https://uk.e-medjournal.com/index.php/psp
GNU General Public License v3.0
31 stars 35 forks source link

Update format of translations #123

Open Mandroide opened 4 years ago

Mandroide commented 4 years ago

Besides moving the files from XML to PO, I fixed the order of the keys and added missing keys.

Note: I recommend to use rebase instead of merge to avoid unnecesary commits.

Mandroide commented 4 years ago

I added #85 #94 #111 as well. So after you rebase these commits, you can go ahead and close all previous PRs.

Vitaliy-1 commented 4 years ago

Thanks, @Mandroide!

According to your recommendation, can you rebase, squash, and force update your branch?

Vitaliy-1 commented 4 years ago

Ahh, your branch has 2 commits on top of the master, looks ok to me. Also, did you check those translations? Let me know if not, I'll take a closer look at them.

Mandroide commented 4 years ago

Ahh, your branch has 2 commits on top of the master, looks ok to me. Also, did you check those translations? Let me know if not, I'll take a closer look at them.

I dit it. But you could check them out just in case.